Skip to content

Conversation

@patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Dec 1, 2020

Related: https://github.com/coinbase/rosetta-cli/tree/patrick/lock-profiling
Closes: #191
Closes: #189
Closes: #170
Blocked By: coinbase/mesh-sdk-go#259

This PR includes significant improvements to the storage package. In our own testing, we observed over a 20x improvement in sync speed and reconciliation rate (mostly due to a reduction in lock contention).

Changes

  • use EstimatedReconciliationCoverage
  • remove unnecessary mocks
  • update rosetta-sdk-go to official release + run go mod tidy
    • fix breaking changes
  • update version
  • Add pruning frequency to config

rosetta-sdk-go Changes

  • [asserter] Backwards Compatibility for Operation.Status #260
  • [chore] Miscellaneous Nits Before Release #259
  • Bump github.com/vmihailenco/msgpack/v5 from 5.0.0 to 5.1.0 #256
  • [reconciler] Performance Overhaul #258
  • feat: support schnorr_1 for zilliqa #257
  • [storage] Small Nits #255
  • [storage] Balance Storage Overhaul #252
  • [storage] Interface Refactor + Test Cleanup #254
  • [storage] Interface Overhaul #251
  • [statefulsyncer] Add Variadic Initializer #250
  • [utils] Implement ShardedMap #248
  • [utils] Add MutexMap #246
  • [utils] Implement PriorityMutex #244
  • [chore] Update msgpack #245

@coveralls
Copy link

coveralls commented Dec 1, 2020

Pull Request Test Coverage Report for Build 6374

  • 19 of 27 (70.37%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.837%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/results/data_results.go 19 22 86.36%
pkg/results/construction_results.go 0 5 0.0%
Totals Coverage Status
Change from base Build 6315: 0.0%
Covered Lines: 506
Relevant Lines: 860

💛 - Coveralls

@patrick-ogrady patrick-ogrady requested a review from yfl92 December 2, 2020 00:22
@patrick-ogrady patrick-ogrady merged commit b046414 into master Dec 2, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/update-sdk-version branch December 2, 2020 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Support for signature type: schnorr_1 memory leak causes data corruption that check:construction not working properly

3 participants