fix(docs): update step 11 to reflect .env usage#17
Open
stackoverflowed1 wants to merge 1 commit into
Open
Conversation
Step 11 in the README previously instructed users to "Fill in CDP project id in `App.tsx` (replace `REPLACE_ME` with the project id)". This is outdated and misleading, as the current App.tsx reads Config.CDP_PROJECT_ID from the .env file and throws an error if it is missing — there is no REPLACE_ME in the code. To clarify, step 11 has been updated to instruct users to ensure CDP_PROJECT_ID is set in `.env` (referencing step 3). This keeps the guide user-friendly for newcomers while removing the inaccurate instruction, without deleting the step entirely.
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Step 11 in the README previously instructed users to "Fill in CDP project id in
App.tsx(replaceREPLACE_MEwith the project id)". This is outdated and misleading, as the current App.tsx reads Config.CDP_PROJECT_ID from the .env file and throws an error if it is missing — there is no REPLACE_ME in the code.To clarify, step 11 has been updated to instruct users to ensure CDP_PROJECT_ID is set in
.env(referencing step 3). This keeps the guide user-friendly for newcomers while removing the inaccurate instruction, without deleting the step entirely.