Skip to content

[PSDK-529] GHA for Linting #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2024
Merged

[PSDK-529] GHA for Linting #5

merged 1 commit into from
Sep 24, 2024

Conversation

@John-peterson-coinbase
Copy link
Contributor

@John-peterson-coinbase John-peterson-coinbase commented Sep 24, 2024

  • Added GHA for linting with ruff
  • Added PR Template

@cb-heimdall
Copy link

cb-heimdall commented Sep 24, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@John-peterson-coinbase John-peterson-coinbase force-pushed the gha-linter-formatter branch 2 times, most recently from e7e421c to 567c3d0 Compare September 24, 2024 18:00
@John-peterson-coinbase John-peterson-coinbase merged commit 1f9d268 into master Sep 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohan-agarwal-coinbase rohan-agarwal-coinbase rohan-agarwal-coinbase approved these changes

@jazz-cb jazz-cb Awaiting requested review from jazz-cb

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@John-peterson-coinbase @cb-heimdall @rohan-agarwal-coinbase