Skip to content

feat: Support Ed25519 key #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 25, 2025
Merged

feat: Support Ed25519 key #111

merged 7 commits into from
Feb 25, 2025

Conversation

@dimei-BT
Copy link

@dimei-BT dimei-BT commented Feb 24, 2025 •
edited
Loading

What changed? Why?

  • Support Ed25519 key
    • Update getEncryptionKey() to support seed import and export using Edwards keys
  • Support key ID along with the full resource name
    • Support both "id" and "name" for the downloaded API key JSON file

How it's tested

  • Unit tests
  • E2E tests with the locally built package

@cb-heimdall
Copy link

cb-heimdall commented Feb 24, 2025 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@dimei-BT dimei-BT changed the title Support ed25519 key 3 feat: Support Edwards key Feb 24, 2025
@dimei-BT dimei-BT marked this pull request as ready for review February 24, 2025 17:26
@dimei-BT dimei-BT changed the title feat: Support Edwards key feat: Support Ed25519 key Feb 24, 2025
alex-stone
alex-stone reviewed Feb 24, 2025
View reviewed changes
@dimei-BT dimei-BT requested a review from alex-stone February 24, 2025 18:58
@dimei-BT dimei-BT changed the base branch from master to v0.20.0 February 24, 2025 21:00
John-peterson-coinbase
John-peterson-coinbase reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@John-peterson-coinbase John-peterson-coinbase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM 🚀

John-peterson-coinbase
John-peterson-coinbase reviewed Feb 24, 2025
View reviewed changes
John-peterson-coinbase
John-peterson-coinbase previously approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@John-peterson-coinbase John-peterson-coinbase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dimei-BT dimei-BT merged commit 62c604b into v0.20.0 Feb 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohan-agarwal-coinbase rohan-agarwal-coinbase rohan-agarwal-coinbase approved these changes

@alex-stone alex-stone Awaiting requested review from alex-stone

@John-peterson-coinbase John-peterson-coinbase Awaiting requested review from John-peterson-coinbase

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dimei-BT @cb-heimdall @alex-stone @John-peterson-coinbase @rohan-agarwal-coinbase