Add new allowConversionToBitmap flag, fixes #773#775
Merged
Conversation
This allows animated transformations and normal transformations to coexist on the same request. If this flag is set to false: - A normal bitmap result will have normal transformations applied to it - An animated result will be left intact which allows animatedTransformations to apply.
Contributor
Author
|
Wasn't sure how to re-generate |
Member
|
Awesome, thanks for adding this! You'll need to run |
Contributor
Author
|
Updated, ptal |
Member
|
@edenman Looks like there are just a couple minor ktlint warnings left. |
Contributor
Author
|
Also had a test failure on api 19, fixed that and the ktlint stuff |
colinrtwhite
approved these changes
Jun 11, 2021
Member
colinrtwhite
left a comment
colinrtwhite
left a comment
There was a problem hiding this comment.
@edenman Awesome, thanks for implementing this!
colinrtwhite
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Add new allowConversionToBitmap flag, fixes #773 This allows animated transformations and normal transformations to coexist on the same request. If this flag is set to false: - A normal bitmap result will have normal transformations applied to it - An animated result will be left intact which allows animatedTransformations to apply. * Update api, add instructions to contributing.md * Add binary compatibility copy method * Add binary compatibility constructor too * Move decoder to ImageLoader to fix tests on pre-28 * Fix ktlint errors * Fix test failure on pre-21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows animated transformations and normal transformations to
coexist on the same request. If this flag is set to false:
animatedTransformations to apply.