Fix Licensee not finding Coil's Licence url#774
Merged
Conversation
It seems that there's a typo on the key for the licence url, according to to what gradle-maven-publish-plugin[1] expects. This typo then causes Licensee[2] to not find Coil's Licence URL, returning null, blocking us from adding it to the allowlist. [1]: https://github.com/vanniktech/gradle-maven-publish-plugin/blob/fc8c5c2982d319c7debf3bc88ac2e1a6e64fcbad/src/main/kotlin/com/vanniktech/maven/publish/MavenPublishBaseExtension.kt#L183 [2]: https://github.com/cashapp/licensee
colinrtwhite
pushed a commit
that referenced
this pull request
Oct 5, 2022
It seems that there's a typo on the key for the licence url, according to to what gradle-maven-publish-plugin[1] expects. This typo then causes Licensee[2] to not find Coil's Licence URL, returning null, blocking us from adding it to the allowlist. [1]: https://github.com/vanniktech/gradle-maven-publish-plugin/blob/fc8c5c2982d319c7debf3bc88ac2e1a6e64fcbad/src/main/kotlin/com/vanniktech/maven/publish/MavenPublishBaseExtension.kt#L183 [2]: https://github.com/cashapp/licensee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks,
It seems that there's a typo on the key for the licence url, according to to what gradle-maven-publish-plugin expects.
This typo then causes Licensee to not find Coil's Licence URL, returning null, blocking us from adding it to the allowlist.
Let me know if there's something else that needs changed, happy to contribute.