Callback support for animated drawables#676
Merged
colinrtwhite merged 8 commits intoFeb 26, 2021
Merged
Conversation
- Add getter and setter extension for start and end callbacks on ImageRequest.Builder. - Apply start and end callbacks through Animatable2.AnimationCallback and Animatable2Compat.AnimationCallback in the ImageDecoderDecoder.kt and GifDecoder.kt respectively.
- Fix import order - Fix code formatting issue
- Remove super call from Animation callbacks. - Minor code enhancements.
…nhancement/gif-callback
…nhancement/gif-callback
- Instrumentation testing on callback for animated drawables - Moved only decoding part to interruptible source in ImageDecoderDecoder.kt
| .data("${ContentResolver.SCHEME_FILE}:///android_asset/animated.gif") | ||
| .build() | ||
| imageLoader.enqueue(imageRequest) | ||
| delay(5000) |
Member
There was a problem hiding this comment.
delay could make the test flaky if the emulator is slow. I'd recommend converting isStartCalled and isEndCalled to MutableStateFlow(false). Then you can start the image request and await them being set to true like here.
Contributor
Author
There was a problem hiding this comment.
I have made the suggested changes. I have one concern here though. What if in the future due to some changes callback won't get triggered, Wouldn't it lead to suspension forever?
Member
There was a problem hiding this comment.
Yep! We could probably add a listener for onSuccess/onError/onCancel, but it awaiting forever is ok too. After ~25 minutes the tests will timeout. By migrating to use the state flow we guarantee that the test will only fail/stall if it's been broken.
- Replace delay in the AnimationCallbacksTest.kt with StateFlow to avoid flaky test. - Fix typo in the GifDecoder.kt
|
Thanks again for this @sagar-viradiya. Works like a charm! |
colinrtwhite
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Support for start and end callbacks for animated drawables - Add getter and setter extension for start and end callbacks on ImageRequest.Builder. - Apply start and end callbacks through Animatable2.AnimationCallback and Animatable2Compat.AnimationCallback in the ImageDecoderDecoder.kt and GifDecoder.kt respectively. * Minor code refactoring - Fix import order - Fix code formatting issue * API dump. * PR review changes. - Remove super call from Animation callbacks. - Minor code enhancements. * Testing and decoder changes - Instrumentation testing on callback for animated drawables - Moved only decoding part to interruptible source in ImageDecoderDecoder.kt * PR review changes - Replace delay in the AnimationCallbacksTest.kt with StateFlow to avoid flaky test. - Fix typo in the GifDecoder.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.