Support preferring exact intrinsic size in CrossfadeDrawable.#585
Merged
Conversation
colinrtwhite
commented
Nov 16, 2020
| public fun <init> (Landroid/graphics/drawable/Drawable;Landroid/graphics/drawable/Drawable;Lcoil/size/Scale;)V | ||
| public fun <init> (Landroid/graphics/drawable/Drawable;Landroid/graphics/drawable/Drawable;Lcoil/size/Scale;I)V | ||
| public fun <init> (Landroid/graphics/drawable/Drawable;Landroid/graphics/drawable/Drawable;Lcoil/size/Scale;IZ)V | ||
| public synthetic fun <init> (Landroid/graphics/drawable/Drawable;Landroid/graphics/drawable/Drawable;Lcoil/size/Scale;IZILkotlin/jvm/internal/DefaultConstructorMarker;)V |
Member
Author
There was a problem hiding this comment.
Argh, this is binary incompatible.
colinrtwhite
force-pushed
the
colin/crossfade_exact_intrinsic_size
branch
from
71546a6 to
8fe832a
Compare
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Support preferring exact intrinsic size in CrossfadeDrawable. * Update API. * Fix binary compatibility. * Docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #223
Fixes: #230
By default,
CrossfadeDrawable's intrinsic size is -1 if either of its child drawables have a -1 intrinsic size. This PR adds an option so its intrinsic size will only be -1 if both of its child drawables have an intrinsic size of -1.This allows a user to use crossfade with
PhotoViewandCircleImageViewsince they both require an exact (>0) intrinsic size.