Add option to disable adding File.lastModified to the cache key.#415
Merged
Conversation
Jawnnypoo
reviewed
May 26, 2020
Jawnnypoo
reviewed
May 26, 2020
| override fun key(data: File) = "${data.path}:${data.lastModified()}" | ||
| override fun key(data: File): String { | ||
| return if (addLastModifiedToFileCacheKey) { | ||
| "${data.path}:${data.lastModified()}" |
Member
There was a problem hiding this comment.
Never would have guessed this triggers a strict mode violation 😮
Member
Author
There was a problem hiding this comment.
Yep! It's very unlikely to cause performance issues as we're only reading the file's metadata, but technically we touch the file system from the main thread.
Jawnnypoo
approved these changes
May 26, 2020
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Add option to disable adding File.lastModified to the cache key. * Fix. * Update API. * Add argument names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #383 by adding an option to disable the
lastModifiedcheck.