Return sealed RequestResult type from ImageLoader.execute(GetRequest).#349
Merged
Conversation
colinrtwhite
force-pushed
the
colin/get_result_type
branch
2 times, most recently
from
b7af743 to
fb5a57c
Compare
Jawnnypoo
approved these changes
Apr 6, 2020
Jawnnypoo
reviewed
Apr 6, 2020
| data class ErrorResult( | ||
| override val drawable: Drawable?, | ||
| val throwable: Throwable | ||
| ) : RequestResult() |
Member
There was a problem hiding this comment.
Are these still usable in Java?
Member
Author
There was a problem hiding this comment.
Yep! Sealed classes are Java compatible.
colinrtwhite
force-pushed
the
colin/get_result_type
branch
2 times, most recently
from
295c8f1 to
1e3e07d
Compare
colinrtwhite
force-pushed
the
colin/get_result_type
branch
from
1e3e07d to
558f6c7
Compare
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
#349) * Return sealed RequestResult type from ImageLoader.execute(GetRequest). * Docs. * Docs. * Delete test code. * Clean imports. * Docs. * Docs. * Update deprecation expression. * Add context parameter to GetRequest. * Update API. * Re-add deprecated constructor. * Update docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has two main benefits:
imageLoader.execute(GetRequest)is now safe by default. Consumers must handle the success/error case. This is more intuitive than having to surround the call in a try/catch.This PR also adds
DataSource.MEMORY_CACHEto indicate if a request is fulfilled from anImageLoader's internal memory cache.Fixes #278.