Skip to content

Only enable inexact size if ImageView has a matching SizeResolver.#344

Merged
colinrtwhite merged 2 commits into
masterfrom
colin/image_view_explicit_size
Apr 4, 2020
Merged

Only enable inexact size if ImageView has a matching SizeResolver.#344
colinrtwhite merged 2 commits into
masterfrom
colin/image_view_explicit_size

Conversation

@colinrtwhite
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown

@joetimmins joetimmins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This change makes a lot of sense, and would help in future.

@colinrtwhite colinrtwhite changed the title Disable allowInexactSize if sizeResolver is set. Only enable inexact size if ImageView has a matching SizeResolver. Apr 4, 2020
@colinrtwhite colinrtwhite merged commit 41e4180 into master Apr 4, 2020
@colinrtwhite colinrtwhite deleted the colin/image_view_explicit_size branch April 4, 2020 06:37
colinrtwhite added a commit that referenced this pull request Oct 5, 2022
)

* Disable allowInexactSize if sizeResolver is set.

* Adjust logic slightly. Add more tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants