Make BitmapFetcher available in common code#3286
Merged
colinrtwhite merged 1 commit intoJan 15, 2026
Merged
Conversation
colinrtwhite
approved these changes
Jan 15, 2026
| ) : Fetcher { | ||
|
|
||
| override suspend fun fetch(): FetchResult { | ||
| return ImageFetchResult( | ||
| image = data.toDrawable(options.context).asImage(), |
Member
There was a problem hiding this comment.
We should probably use asImage(resources) here on Android (for automatic density scaling), however that's a separate issue. You're right data.toDrawable(options.context).asImage() is equivalent to data.asImage().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our compose multiplatform project we noticed that on iOS Coil was unable to display in-memory images (
coil3.Bitmapinstances) because there is no fetcher registered. On Android this does work out of the box due to the existence of aBitmapFetcher. I could see no reason why this should be implemented only for Android, and so in this PR I've moved the implementation to common code.The Android implementation originally called
data.toDrawable(options.context).asImage(), but thetoDrawable(...)step in-between is basically a no-op as far as I can tell, so it should be safe to just leave that out.