Introduce EventListener.#314
Merged
Merged
Conversation
colinrtwhite
changed the title
colinrtwhite
force-pushed
the
colin/event_listener
branch
from
014cb54 to
fef5db3
Compare
colinrtwhite
force-pushed
the
colin/event_listener
branch
from
fd8348a to
0a4887c
Compare
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Introduce EventListener. Change Request.Listener to receive the request. * Pass Options as well. * Docs. * Re-arrange. * Docs. * Docs. * Add test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce an ImageLoader-scoped listener named
EventListener. This is useful for analytics, performance, or other metrics tracking.Fixes #310.
BREAKING CHANGE: Pass the full request object to
Request.Listenerinstead of just its data.