Rename ImageLoaderProvider to ImageLoaderFactory.#311
Merged
Conversation
Jawnnypoo
reviewed
Mar 12, 2020
| @Synchronized | ||
| fun setImageLoader(provider: ImageLoaderProvider) { | ||
| imageLoaderProvider = provider | ||
| fun setImageLoader(factory: ImageLoaderFactory) { |
Member
There was a problem hiding this comment.
Should the method be setImageLoaderFactory instead?
Member
There was a problem hiding this comment.
Actually, I get it now. Probably best to keep it like this so the consumer gets a choice of how they want to provide the image loader 👍
Member
Author
There was a problem hiding this comment.
Yep, I think it'll make more sense too when we can make ImageLoaderFactory a fun interface in Kotlin 1.4 so it's callable using Coil.setImageLoader { ImageLoader(context) }. Mostly I wanted to give both methods the same name to show they overwrite each other.
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Rename ImageLoaderProvider to ImageLoaderFactory. * Emphasize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thought about this some more and
Providerdoesn't feel right even though it's in line withAndroidX. Rename toImageLoaderFactoryandnewImageLoaderto imply creation. This is continues follows the API naming convention inOkHttp. @Jawnnypoo you were right!