Support extracting video image by frame index#2183
Merged
Conversation
| * When both [videoFrameIndex] and other videoFrame-prefixed properties are set, | ||
| * [videoFrameIndex] will take precedence. | ||
| */ | ||
| fun ImageRequest.Builder.videoFrameIndex(frameIndex: Int) = apply { |
Member
There was a problem hiding this comment.
Let's annotate these methods with @RequiresApi(28) since they need API 28 to work.
Contributor
Author
There was a problem hiding this comment.
Sure thing. I've added it to the README too.
colinrtwhite
approved these changes
Mar 26, 2024
Member
colinrtwhite
left a comment
colinrtwhite
left a comment
There was a problem hiding this comment.
Nice! Thanks for implementing this. Left one comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2180.
This changeset adds the
videoFrameIndexoption to theVideoFrameDecoder, which allows extracting an image from videos by its index (frame number).