feat(gcp): add network tags support for peer pod VMs#25
Merged
yousef-cohere merged 3 commits intocoherefrom Apr 22, 2026
Merged
feat(gcp): add network tags support for peer pod VMs#25yousef-cohere merged 3 commits intocoherefrom
yousef-cohere merged 3 commits intocoherefrom
Conversation
GCP network tags (distinct from Resource Manager tags) are simple strings applied to instances at creation time for firewall rule targeting. This adds a GCP_NETWORK_TAGS config key (comma-separated) that sets Instance.Tags.Items on the Instances.Insert request, allowing firewall rules targeting peerpods-vm to apply to dynamically created peer pod VMs. Made-with: Cursor
yousef-cohere
force-pushed
the
yousef/gcp-network-tags-v2
branch
from
a7497b4 to
6f04fa6
Compare
Moved the GCP_NETWORK_TAGS configuration section to improve clarity and organization within the gcp.yaml file. This change enhances the readability of the configuration options for GCP peer pod VMs.
alhassankhedr-cohere
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCP network tags (distinct from Resource Manager tags) are simple strings applied to instances at creation time for firewall rule targeting. This adds a GCP_NETWORK_TAGS config key (comma-separated) that sets Instance.Tags.Items on the Instances.Insert request, allowing firewall rules targeting peerpods-vm to apply to dynamically created peer pod VMs.
Made-with: Cursor
Note
Low Risk
Low risk: adds an optional config/flag that maps directly to GCE instance
Tags.Itemswithout changing existing defaults or instance-creation flow when unset.Overview
Adds support for setting GCE network tags on dynamically created peer pod VMs via a new comma-separated
GCP_NETWORK_TAGSconfig/flag.The GCP provider now parses
--network-tags/GCP_NETWORK_TAGS, stores it in config, and (when provided) setsInstance.Tags.Itemson theInstances.Insertrequest; the Helmgcp.yamlvalues are updated to document the new option.Reviewed by Cursor Bugbot for commit 3d3d7a5. Bugbot is set up for automated code reviews on this repo. Configure here.