Skip to content

Comments

refactor(react-components): Make expandBoundingBox virtual#5320

Draft
nilscognite wants to merge 6 commits intomasterfrom
np/bounding-box
Draft

refactor(react-components): Make expandBoundingBox virtual#5320
nilscognite wants to merge 6 commits intomasterfrom
np/bounding-box

Conversation

@nilscognite
Copy link
Contributor

Type of change

Feat
Bug
Test
Docs
Style
Refactor
Chore

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am happy with this implementation.
  • I have performed a self-review of my own code.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have added documentation to new and changed elements; both public and internally shared ones
  • I have refactored the code for testability, readability and extendibility to the best of my ability.
  • I have listed the JIRA tasks covering remaining work or tech debt related to this PR in the description.

@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 67.44186% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.93%. Comparing base (ce93d23) to head (0036eec).

Files with missing lines Patch % Lines
...age360Collection/Image360CollectionDomainObject.ts 22.22% 7 Missing ⚠️
...chitecture/concrete/terrain/TerrainDomainObject.ts 63.63% 4 Missing ⚠️
.../Image360Collection/Image360CollectionThreeView.ts 0.00% 1 Missing ⚠️
...c/architecture/concrete/reveal/cad/CadThreeView.ts 0.00% 1 Missing ⚠️
.../concrete/reveal/pointCloud/PointCloudThreeView.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5320   +/-   ##
=======================================
  Coverage   65.92%   65.93%           
=======================================
  Files        1191     1191           
  Lines       83829    83836    +7     
  Branches     8033     8036    +3     
=======================================
+ Hits        55266    55275    +9     
+ Misses      28457    28455    -2     
  Partials      106      106           
Files with missing lines Coverage Δ
...rc/architecture/base/domainObjects/DomainObject.ts 89.71% <100.00%> (+0.10%) ⬆️
...tecture/concrete/primitives/box/BoxDomainObject.ts 74.66% <100.00%> (ø)
...ncrete/primitives/cylinder/CylinderDomainObject.ts 75.00% <100.00%> (ø)
...cture/concrete/primitives/line/LineDomainObject.ts 94.21% <100.00%> (-0.18%) ⬇️
...rchitecture/concrete/reveal/cad/CadDomainObject.ts 100.00% <100.00%> (ø)
...ncrete/reveal/pointCloud/PointCloudDomainObject.ts 100.00% <100.00%> (ø)
.../architecture/concrete/terrain/TerrainThreeView.ts 81.81% <100.00%> (+1.30%) ⬆️
.../Image360Collection/Image360CollectionThreeView.ts 85.18% <0.00%> (+16.61%) ⬆️
...c/architecture/concrete/reveal/cad/CadThreeView.ts 85.18% <0.00%> (+5.18%) ⬆️
.../concrete/reveal/pointCloud/PointCloudThreeView.ts 85.18% <0.00%> (+5.18%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant