Remove deprecated options #906
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove BrowseCallback which doesn't work and hasn't worked for _a long time_, it never worked with OIDC...
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively removes several deprecated configuration options and their corresponding logic from the codebase. The changes are consistent across configuration classes, interfaces, processing logic, tests, and schema files. The removal of BrowseCallback and its usage is also handled correctly. This is a solid cleanup effort that simplifies the code and removes legacy cruft. I have no issues to report.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #906 +/- ##
==========================================
+ Coverage 79.76% 80.11% +0.35%
==========================================
Files 132 132
Lines 18365 18204 -161
Branches 2752 2724 -28
==========================================
- Hits 14649 14585 -64
+ Misses 2876 2795 -81
+ Partials 840 824 -16
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #764, which was originally merged into v3-dev.
Simply removing a few deprecated options, and
BrowseCallbackwhich doesn't work, and isn't particularly useful anymore.