Skip to content

Fix NameVisitor map selection for issues #333 and #336#363

Merged
coenjacobs merged 3 commits into
masterfrom
fix/namevisitor-issues-333-and-336
Mar 12, 2026
Merged

Fix NameVisitor map selection for issues #333 and #336#363
coenjacobs merged 3 commits into
masterfrom
fix/namevisitor-issues-333-and-336

Conversation

@coenjacobs
Copy link
Copy Markdown
Owner

@coenjacobs coenjacobs commented Mar 12, 2026 •
edited
Loading

  • route NameVisitor replacements by symbol type so function and constant nodes are handled by their parent nodes
  • fix existence-check string replacement to use the correct symbol map and keep handling in class-only context
  • add regressions for class/function and class/constant collisions in both NameVisitor and NameReplacer

This was linked to issues Mar 12, 2026
NameVisitor existence check replacement doesn't distinguish function types #333
Closed
NameVisitor applies classmap replacement to Name children of FuncCall/ConstFetch before parent handles them #336
Closed
@coenjacobs coenjacobs merged commit 056445c into master Mar 12, 2026
11 checks passed
@coenjacobs coenjacobs deleted the fix/namevisitor-issues-333-and-336 branch March 12, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

1 participant

@coenjacobs