chore: add missing netcheck report fields to netinfo #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tailscale chooses not to expose
netcheck.Report, and instead opts to maketailcfg.NetInfoavailable via a callback, which is built using aReport. There's a few pieces of data inReportthat we'd like to have for our network telemetry.Furthermore,
NetInfois not a proper subset ofReport, so replacing it is non-trivial.We should instead make
NetInfoa superset ofReport, as a means of future-proofing what we have access to from Tailscale in our network telemetry.