fix: remove unused coder-organization from code path#17
Open
fix: remove unused coder-organization from code path#17
Conversation
The input was read, validated, and logged but never passed to any API call. This misleads users into thinking the action can be scoped to a specific organization. Keep the input in action.yaml for backwards compatibility but add deprecationMessage so GitHub surfaces a warning. Remove it from the schema, index.ts, and all test fixtures.
mafredri
force-pushed
the
fix/unused-coder-organization
branch
from
d2a046c to
41f059c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
coder-organizationinput was accepted, validated, and logged, but never used by any API call. Six of seven reviewers flagged this. Users setting it would reasonably expect it to scope the action to that organization.Removes validation and reading from the code path. The action.yaml input is kept with a
deprecationMessagefor backwards compatibility. GitHub will surface a warning to any workflow that sets it.Also fixes
required: truein index.ts which contradicted action.yaml'srequired: false.Found by review panel (Bisky, Hisoka, Robin, Komugi, Luffy, Killua).