fix cleaning the wrong top node #896
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, `top_node` was cleaned and then copied to the `clean_top_node`. I believe this is not the original intent and should be fixed because it creates confusion and there's no way to get the raw `top_node`
Signed-off-by: Viktor Poluksht <[email protected]>
Signed-off-by: Viktor Poluksht <[email protected]>
Signed-off-by: Viktor Poluksht <[email protected]>
final_url stores the actual url used to fetch the html after redirects and meta refresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
top_nodewas cleaned and then copied to theclean_top_node.I believe this is not the original intent and should be fixed because it creates confusion and there's no way to get the raw
top_node. It's an issue I'm currently facing myself.Thanks for your awesome work!