Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

Conversation

@scott-codecov
Copy link
Contributor

@scott-codecov scott-codecov commented Nov 3, 2023

Cherry picked from #316 to get a signed commit
Closes #316

@codecov
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (424e8ee) 95.48% compared to head (6cf4f9c) 95.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   95.48%   95.44%   -0.04%     
==========================================
  Files          80       80              
  Lines        2723     2702      -21     
==========================================
- Hits         2600     2579      -21     
  Misses        123      123              
Flag Coverage Δ
python3.10 95.69% <100.00%> (-0.04%) ⬇️
python3.11 95.68% <100.00%> (-0.04%) ⬇️
python3.8 95.69% <100.00%> (-0.04%) ⬇️
python3.9 95.69% <100.00%> (-0.04%) ⬇️
smart-labels 95.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zetaab
Copy link
Contributor

zetaab commented Nov 14, 2023

@scott-codecov @dana-yaish could this be merged as its blocking codecov/codecov-action#1054

dana-yaish
dana-yaish previously approved these changes Nov 14, 2023
Copy link
Contributor

@dana-yaish dana-yaish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* heads/main:
  simplify the ternary operator
  amend branch names to be forked-slug:branch-name
  we need the pr number for the PR API request to know if the command runs in a fork PR
  chore: Fix helper text in label analysis (#315)
  taking decoding slug out of is_fork_pr, cause it doesn't feel right to be there
  adding tests
  check if the PR is a fork PR
  chore: remove smart-open (#326)
Copy link
Contributor

@dana-yaish dana-yaish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to fix the failing tests


import click

from codecov_cli.fallbacks import CodecovOption, FallbackFieldEnum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that the tests are failing because CodecovOption stopped being imported here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scott-codecov scott-codecov merged commit b304bf0 into main Nov 27, 2023
@scott-codecov scott-codecov deleted the scott/token-validation branch November 27, 2023 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants