Fix bug viewport bug in RenderTextureWebGLRender#3480
Open
ntrrgc wants to merge 1 commit intococos2d:developfrom
Open
Fix bug viewport bug in RenderTextureWebGLRender#3480ntrrgc wants to merge 1 commit intococos2d:developfrom
ntrrgc wants to merge 1 commit intococos2d:developfrom
Conversation
…content scale factor
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GL viewport did not account for content scale factor, which also resulted in a wrong projection.
For instance, this screenshot was taken with contentScaleFactor = 2. The
RenderTexturenode has a red clear color to make it easy to distinguish from the rest of the scene. It should contain a screenshot of the rest of the nodes. However, instead of them being centered, as in the real scene, they only use one quadrant in the screenshot. This PR fixes that bug.