storage: check for panics before updating the proposalQuota #39193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cockroachdb#39188 we see a fatal assertion failure fire because an invariant is violated while running a deferred function. It is true that the invariant is violated but it's violated because the goroutine is panicking and the function which maintains this invariant was not run to completion. This commit detects panics and avoid running the function which might fatal the process. Release note: None
Member
|
This change is |
Contributor
Author
|
Superseded by #39203. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #39188 we see a fatal assertion failure fire because an invariant is violated
while running a deferred function. It is true that the invariant is violated but
it's violated because the goroutine is panicking and the function which
maintains this invariant was not run to completion.
This commit detects panics and avoid running the function which might fatal the
process.
Release note: None