Skip to content

Conversation

@rafiss
Copy link
Collaborator

@rafiss rafiss commented Nov 13, 2024

The lib/pq driver is not maintained. Since we started to see flakes related to how that driver does error handling for secure connections, we switch to pgx instead.

fixes #127745
fixes #131532
fixes #131110
fixes #133360

Release note: None

@rafiss rafiss added backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only backport-23.2.x PAST MAINTENANCE SUPPORT: 23.2 patch releases via ER request only backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x backport-24.3.x Flags PRs that need to be backported to 24.3 labels Nov 13, 2024
@rafiss rafiss requested a review from souravcrl November 13, 2024 16:43
@rafiss rafiss requested a review from a team as a code owner November 13, 2024 16:43
@rafiss rafiss requested review from a team November 13, 2024 16:43
@rafiss rafiss requested review from a team as code owners November 13, 2024 16:43
@rafiss rafiss removed request for a team November 13, 2024 16:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss force-pushed the pgx-auth-tests branch 4 times, most recently from 511ccc0 to c956621 Compare November 13, 2024 22:36
The lib/pq driver is not maintained. Since we started to see flakes
related to how that driver does error handling for secure connections,
we switch to pgx instead.

Release note: None
@rafiss
Copy link
Collaborator Author

rafiss commented Nov 14, 2024

bors r+

@craig craig bot merged commit afd5d06 into cockroachdb:master Nov 14, 2024
23 checks passed
@blathers-crl
Copy link

blathers-crl bot commented Nov 14, 2024

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #133360: branch-release-23.1, branch-release-23.2, branch-release-24.1, branch-release-24.2.


Issue #127745: branch-release-23.2, branch-release-24.1, branch-release-24.2, branch-release-24.3.


Issue #131532: branch-release-23.1, branch-release-23.2, branch-release-24.1, branch-release-24.2, branch-release-24.3.


Issue #131110: branch-release-23.1, branch-release-24.1, branch-release-24.2, branch-release-24.3.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl
Copy link

blathers-crl bot commented Nov 14, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from f1808af to blathers/backport-release-23.1-135086: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


error creating merge commit from f1808af to blathers/backport-release-23.2-135086: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


error creating merge commit from f1808af to blathers/backport-release-24.1-135086: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.1.x failed. See errors above.


error creating merge commit from f1808af to blathers/backport-release-24.2-135086: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.2.x failed. See errors above.


error setting reviewers, but backport branch blathers/backport-release-24.3-135086 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/135165/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 24.3.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only backport-23.2.x PAST MAINTENANCE SUPPORT: 23.2 patch releases via ER request only backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.3.x Flags PRs that need to be backported to 24.3

Projects

None yet

3 participants