Skip to content

Conversation

@technosophos
Copy link
Member

@technosophos technosophos commented Feb 25, 2020

This PR is the candidate release for CNAB Core 1.0.1

The following people need to vote on ratifying this specification:

@radu-matei
@simonferquel
@technosophos
@jeremyrickard
@silvin-lubecki

The following changes have been included as part of CNAB 1.0.1:

Signed-off-by: Matt Butcher [email protected]

Signed-off-by: Matt Butcher <[email protected]>
@technosophos
Copy link
Member Author

I vote 👍

@chris-crone
Copy link
Contributor

@rumpl caught last time we cut a release that we didn't update the 101-bundle-json.md. Doing:

$ git grep 1\.0\.\0

I see that we still have:

...
101-bundle-json.md:- The schema version of the bundle, as a string with a `v` prefix. This schema is to be referenced as `v1` or `v1.0.0`
101-bundle-json.md:   "schemaVersion":"v1.0.0",
101-bundle-json.md:{"credentials":{"hostkey":{"env":"HOST_KEY","path":"/etc/hostkey.txt"}},"custom":{"com.example.backup-preferences":{"frequency":"daily"},"com.example.duffle-bag":{"icon":"https://example.com/icon.png","iconType":"PNG"}},"definitions":{"http_port":{"default":80,"maximum":10240,"minimum":10,"type":"integer"},"port":{"maximum":65535,"minimum":1024,"type":"integer"},"string":{"type":"string"},"x509Certificate":{"contentEncoding":"base64","contentMediaType":"application/x-x509-user-cert","type":"string","writeOnly":true}},"description":"An example 'thin' helloworld Cloud-Native Application Bundle","images":{"my-microservice":{"contentDigest":"sha256:aaaaaaaaaaaa...","description":"my microservice","image":"example/microservice:1.2.3"}},"invocationImages":[{"contentDigest":"sha256:aaaaaaa...","image":"example/helloworld:0.1.0","imageType":"docker"}],"maintainers":[{"email":"[email protected]","name":"Matt Butcher","url":"https://example.com"}],"name":"helloworld","outputs":{"clientCert":{"definition":"x509Certificate","path":"/cnab/app/outputs/clientCert"},"hostName":{"applyTo":["install"],"definition":"string","description":"the hostname produced installing the bundle","path":"/cnab/app/outputs/hostname"},"port":{"definition":"port","path":"/cnab/app/outputs/port"}},"parameters":{"backend_port":{"definition":"http_port","description":"The port that the back-end will listen on","destination":{"env":"BACKEND_PORT"}}},"schemaVersion":"v1.0.0","version":"0.1.2"}
101-bundle-json.md:   "schemaVersion":"v1.0.0",
101-bundle-json.md:   "version":"1.0.0"
101-bundle-json.md:The current schema version is `v1.0.0`, which is considered stable.
101-bundle-json.md:   "schemaVersion":"v1.0.0",
...
examples/101.01-bundle.json:  "schemaVersion": "v1.0.0",
examples/101.02-bundle.json:  "schemaVersion": "v1.0.0",
examples/101.02-bundle.json:  "version": "1.0.0"
examples/101.03-bundle.json:  "schemaVersion": "v1.0.0",
examples/400.01-claim.json:    "schemaVersion": "v1.0.0",

I think it would make the spec clearer if we use the current version in these places.

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @chris-crone changes

@technosophos
Copy link
Member Author

Thanks for catching those @chris-crone . I acknowledge your grepping skills as superior to my own. 😄 I have fixed those instances.

Copy link
Contributor

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @technosophos!

LGTM

@technosophos
Copy link
Member Author

Just awaiting an LGTM from @simonferquel

Copy link
Contributor

@simonferquel simonferquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technosophos
Copy link
Member Author

At the CNAB meeting this morning, we finalized the decision to commit this. I am pushing it to branch cnab-core-v1.0.1.

@technosophos
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants