[Hunter] Fix clever Traps increasing freezing trap duration in PvP#757
Draft
miraco wants to merge 2 commits intocmangos:masterfrom
Draft
[Hunter] Fix clever Traps increasing freezing trap duration in PvP#757miraco wants to merge 2 commits intocmangos:masterfrom
miraco wants to merge 2 commits intocmangos:masterfrom
Conversation
Freezing Trap should have a 10/11.5/13 sec duration in pvp if hunter has Clever Traps skilled cmangos/issues#3126
Contributor
|
Ok so, the spells have SPELLMOD_DURATION - i.e. thats what should do the 15% and 30% increase Currently I have no understanding if all spellmods should affect pvp duration or just this one. Return in all cases 10000, (it still needs the spell script i might add) and let spell_affect take care of the rest. Make sure clever traps has mask of freezing trap effect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Freezing Trap should have a 10/11.5/13 sec duration in pvp if hunter has Clever Traps skilled
🍰 Pullrequest
Proof
Video 1
Issues
Fixes cmangos/issues#3126
How2Test
Todo / Checklist
Testing multiple situations