Skip to content

Drop legacy HHVM support #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clue merged 1 commit into from
Nov 27, 2020
Merged

Drop legacy HHVM support #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ jobs:
- php: 7.2
- php: 7.3
- php: 7.4
- php: hhvm-3.18
install: composer require phpunit/phpunit:^5 --dev
- name: "Windows"
os: windows
language: shell # no built-in php support
Expand All @@ -27,7 +25,6 @@ jobs:
- php -r "file_put_contents(php_ini_loaded_file(),'extension_dir=ext'.PHP_EOL,FILE_APPEND);"
- php -r "file_put_contents(php_ini_loaded_file(),'extension=sockets'.PHP_EOL,FILE_APPEND);"
allow_failures:
- php: hhvm-3.18
- os: windows

install:
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ See also the [CHANGELOG](CHANGELOG.md) for details about version upgrades.

This project aims to run on any platform and thus does not require any PHP
extensions besides `ext-sockets` and supports running on legacy PHP 5.3 through
current PHP 7+ and HHVM.
current PHP 7+.
It's *highly recommended to use PHP 7+* for this project.

## Tests
Expand Down
3 changes: 1 addition & 2 deletions tests/SocketTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,7 @@ public function testServerNonBlockingAcceptNobody(Socket $server)
$server->accept();
$this->fail('accept() MUST throw an exception');
} catch (Exception $e) {
// code should usually be SOCKET_EAGAIN, hhvm uses SOCKET_EBADF, so let's play it safe
$this->assertNotEquals(0, $e->getCode());
$this->assertEquals(SOCKET_EWOULDBLOCK, $e->getCode());
}
}

Expand Down