Simplify examples by updating to new default loop #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
reviewed
Aug 2, 2021
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for looking into this!
| "require-dev": { | ||
| "phpunit/phpunit": "^9.3 || ^5.7 || ^4.8", | ||
| "react/event-loop": "^1.0 || ^0.5 || ^0.4 || ^0.3" | ||
| "react/event-loop": "^1.2" |
Owner
There was a problem hiding this comment.
I don't think the updated examples reference the event loop at all?
Contributor
Author
There was a problem hiding this comment.
The event loop is still necessary for some tests (see FunctionalControlCodeParserTest.php).
SimonFrings
changed the title
clue
approved these changes
Aug 4, 2021
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset simplifies usage by using the new default loop.
Builds on top of reactphp/event-loop#229, reactphp/event-loop#232 and reactphp/stream#159