Refactor: use $_SERVER instead of getenv() #91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation does not permit storing the default address to listen to, as it is hardcoded.
By using
$_SERVERinstead ofgetenv()to check for theX_LISTENenv var, one could use a dotenv library such assymfony/dotenvto read.envfiles and populateX_LISTEN.This could help devs override the default port to listen to (in case something else already use 127.0.0.1:8080 in their projects), and override the default port in their
.env.local.Example here: https://github.com/bpolaszek/freddie/blob/main/.env.test#L11 (this actually doesn't work and I had to specify the "real" env var in the CI)