Skip to content

Update documentation for Last-Modified header to avoid deprecated DATE_RFC7231 constant (PHP 8.5+) #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clue merged 1 commit into from
Aug 19, 2025
Merged

Update documentation for Last-Modified header to avoid deprecated DATE_RFC7231 constant (PHP 8.5+) #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions docs/api/response.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ $app->get('/user', function (Psr\Http\Message\ServerRequestInterface $request) {
<h1>Hello Alice</h1>
HTML;

$modified = $date->setTimezone(new DateTimeZone('UTC'))->format(DATE_RFC7231);
$modified = gmdate('D, d M Y H:i:s T', $date->getTimestamp());
if ($request->getHeaderLine('If-Modified-Since') === $modified) {
return new React\Http\Message\Response(
React\Http\Message\Response::STATUS_NOT_MODIFIED,
Expand Down Expand Up @@ -481,11 +481,19 @@ Last-Modified: Sat, 06 Nov 2021 12:31:04 GMT

> ℹ️ **Working with dates**
>
> For use in HTTP, you may format any date in the GMT/UTC timezone using the
> [`DATE_RFC7231`](https://www.php.net/manual/en/class.datetimeinterface.php#datetime.constants.rfc7231)
> (PHP 7.1.5+) constant as given above. If you don't know the modification date
> for your response or don't want to expose this information, you may want to
> use [`ETag`](#etag) headers from the previous section instead.
> For use in HTTP, you may format any date using the GMT time zone and the exact
> format as given above. While UTC and GMT are often used interchangeably, the
> HTTP specs require dates to be formatted in GMT.
>
> ```php
> // convert date to GMT first, both forms are equivalent
> $modified = gmdate('D, d M Y H:i:s T', $date->getTimestamp());
> $modified = $date->setTimezone(new DateTimeZone('GMT'))->format('D, d M Y H:i:s T');
> ```
>
> If you don't know the modification date for your response or don't want to
> expose this information, you may want to use [`ETag`](#etag) headers from the
> previous section instead.

## Output buffering

Expand Down
2 changes: 1 addition & 1 deletion src/FilesystemHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public function __invoke(ServerRequestInterface $request): ResponseInterface

$stat = @\stat($path);
if ($stat !== false) {
$headers['Last-Modified'] = \gmdate('D, d M Y H:i:s', $stat['mtime']) . ' GMT';
$headers['Last-Modified'] = \gmdate('D, d M Y H:i:s T', $stat['mtime']);

if ($request->getHeaderLine('If-Modified-Since') === $headers['Last-Modified']) {
return new Response(Response::STATUS_NOT_MODIFIED);
Expand Down