Add compression to dev environment to match production configuration #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
approved these changes
Jul 4, 2024
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for looking into this, changes LGTM! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the configuration for the dev environment by enabling HTTP compression (brotli and gzip). Our production system uses a content delivery network (CDN) which uses brotli compression by default with a possible fallback to gzip. Our current dev environment configuration doesn't allow compression, which will change through my suggestion and thus better aligns our production environment and our dev environment.
As a first step, I made sure that our production system works with the improved integration tests like this:
Once the test suite confirmed my changes, I improved the dev configuration and ran the same tests against the new dev environment:
This is also confirmed by our automated test suite (which uses dev environment), so I think this pull request is save to apply and will have no impact on the production system 👍
Builds on top of #40 and others.