Use GitHub actions for continuous integration (CI) #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@clue don't forget to activate GitHub actions. |
clue
approved these changes
Jul 8, 2021
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 
Owner
|
After approving, I just noticed the legacy HHVM build currently fails. Is this something you can look into? |
Bye bye Travis CI, you've served us well.
Contributor
Author
|
I took a look and it seems like HHVM can't even execute confgen properly. I don't see a fast solution to this other then to drop HHVM support in a following pull request. Part of this reason is HHVM's decrease in use (if no one uses it why going through the trouble). |
Owner
|
Fair point, let's get this in as-is and drop HHVM support entirely in a follow-up PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bye bye Travis CI, you've served us well.
Builds on top of reactphp/reactphp#442.