Skip to content

Add missing supports implementations in SQL generation code #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2021
Merged

Add missing supports implementations in SQL generation code #102

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43e2e5b
fix: add missing `supports` implementations in sql generation code
andrew-james-dev Oct 3, 2021
98bfba9
Merge branch 'cloudspannerecosystem:master' into master
andrew-james-dev Oct 21, 2021
c4ba9fa
style: removed extraneous empty lines
andrew-james-dev Oct 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .../liquibase/ext/spanner/sqlgenerator/CreateDatabaseChangeLogLockTableGeneratorSpanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import liquibase.sqlgenerator.SqlGeneratorChain;
import liquibase.sqlgenerator.core.CreateDatabaseChangeLogLockTableGenerator;
import liquibase.statement.core.CreateDatabaseChangeLogLockTableStatement;
import liquibase.ext.spanner.ICloudSpanner;

public class CreateDatabaseChangeLogLockTableGeneratorSpanner
extends CreateDatabaseChangeLogLockTableGenerator {
Expand All @@ -31,4 +32,9 @@ public Sql[] generateSql(
public int getPriority() {
return PRIORITY_DATABASE;
}

@Override
public boolean supports(CreateDatabaseChangeLogLockTableStatement statement, Database database) {
return (database instanceof ICloudSpanner);
}
}
6 changes: 6 additions & 0 deletions src/main/java/liquibase/ext/spanner/sqlgenerator/CreateTableGeneratorSpanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import liquibase.sqlgenerator.core.CreateTableGenerator;
import liquibase.statement.core.CreateTableStatement;
import liquibase.structure.DatabaseObject;
import liquibase.ext.spanner.ICloudSpanner;

public class CreateTableGeneratorSpanner extends CreateTableGenerator {

Expand Down Expand Up @@ -75,4 +76,9 @@ public Sql[] generateSql(
public int getPriority() {
return PRIORITY_DATABASE;
}

@Override
public boolean supports(CreateTableStatement statement, Database database) {
return (database instanceof ICloudSpanner);
}
}
9 changes: 9 additions & 0 deletions ...java/liquibase/ext/spanner/sqlgenerator/InitializeChangeLogLockTableGeneratorSpanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import liquibase.statement.core.DeleteStatement;
import liquibase.statement.core.InitializeDatabaseChangeLogLockTableStatement;
import liquibase.statement.core.InsertStatement;
import liquibase.ext.spanner.ICloudSpanner;

public class InitializeChangeLogLockTableGeneratorSpanner
extends AbstractSqlGenerator<InitializeDatabaseChangeLogLockTableStatement> {
Expand Down Expand Up @@ -62,4 +63,12 @@ public Sql[] generateSql(
},
database);
}

@Override
public boolean supports(InitializeDatabaseChangeLogLockTableStatement statement, Database database) {
return (database instanceof ICloudSpanner);
}

}


Copy link
Collaborator

@olavloite olavloite Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove extraneous empty line

Copy link
Contributor Author

@andrew-james-dev andrew-james-dev Oct 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be resolved now.

Copy link
Collaborator

@olavloite olavloite Oct 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

1 change: 1 addition & 0 deletions src/main/java/liquibase/ext/spanner/sqlgenerator/InsertOrUpdateGeneratorSpanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,5 @@ protected String getRecordCheck(InsertOrUpdateStatement insertOrUpdateStatement,
protected String getElse(Database database) {
return "";
}

}
6 changes: 6 additions & 0 deletions src/main/java/liquibase/ext/spanner/sqlgenerator/InsertWithSelectGeneratorSpanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import liquibase.sqlgenerator.core.InsertGenerator;
import liquibase.statement.DatabaseFunction;
import liquibase.statement.core.InsertStatement;
import liquibase.ext.spanner.ICloudSpanner;

/** Generator for INSERT statements in the form 'INSERT INTO FOO (..) SELECT ...'. */
public class InsertWithSelectGeneratorSpanner extends InsertGenerator {
Expand All @@ -35,6 +36,11 @@ public int getPriority() {
return 0;
}

@Override
public boolean supports(InsertStatement statement, Database database) {
return (database instanceof ICloudSpanner);
}

@Override
public Sql[] generateSql(InsertStatement statement, Database database,
SqlGeneratorChain sqlGeneratorChain) {
Expand Down