feat: add performance insights variable

[RoseSecurity]

what and why

Note

The module already supports this functionality (we just need to pass the variable)

• Provide the ability to enable performance insights for the DocumentDB cluster

references

• Performance Insights
• Terraform Docs

Summary by CodeRabbit

• New Features
  • Introduced an option to enable Performance Insights for enhanced database monitoring.
  • Updated the database cluster module to a newer version for improved functionality.
  • Added support for configurable master user password management with improved security handling.

[coderabbitai]

"""

Walkthrough

The pull request upgrades the DocumentDB cluster module version from 0.14.0 to 0.30.0, adds a new boolean parameter enable_performance_insights, introduces a nullable master_password variable, and changes master credentials handling from concatenating multiple SSM values to selecting a single password. Test code was refined for type usage, naming consistency, and input parameter handling without altering test logic.

Changes

File(s)	Change Summary
src/main.tf, src/variables.tf, src/ssm.tf	Upgraded documentdb_cluster module version to 0.30.0; added enable_performance_insights parameter; introduced master_password (nullable string) and enable_performance_insights (bool, default false) variables; replaced master credentials extraction from concatenation (join) to single selection (one); added local variable create_password and conditional password assignment.
test/component_test.go	Improved test code by changing map type to map[string]any, adding fmt import, updating input parameters including "master_password" with a generated password, formatting "name", and enhancing variable naming consistency; no changes to test logic or assertions.

Poem

I hop with joy through code anew,
A flag to guide what we can do.
Insights bright to help us see,
DocumentDB runs swift and free!
From CodeRabbit’s burrow, cheers for me! 🐇✨
"""

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between baa1c3d and e24d389.

📒 Files selected for processing (1)

• src/main.tf (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/main.tf

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[RoseSecurity]

I'm not sure why these tests are failing as we are currently using this code in our downstream component and it works as intended

[mergify]

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

[mergify]

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

[RoseSecurity]

/terratest

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

test/component_test.go (1)

22-87: Consider adding test coverage for performance insights functionality.

While the test improvements are excellent, the PR objectives mention adding performance insights functionality to the DocumentDB module. Consider adding test assertions to verify that performance insights can be enabled and configured correctly.

Would you like me to help generate additional test cases that specifically verify the performance insights functionality?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4c3343 and 4b1879e.

📒 Files selected for processing (1)

• test/component_test.go (5 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Summary

🔇 Additional comments (9)

test/component_test.go (9)

5-5: LGTM! Import addition supports string formatting.

The fmt import is correctly added to support the fmt.Sprintf usage in the test inputs.

---

28-28: LGTM! Password variable addition supports master password testing.

The addition of a randomly generated password variable aligns with the new manage_master_user_password functionality mentioned in the PR objectives.

---

31-31: LGTM! Type improvement using any instead of interface{}.

Using any (alias for interface{} introduced in Go 1.18) is more concise and idiomatic in modern Go code.

---

33-33: LGTM! Master password input addition supports new functionality.

The addition of master_password to the test inputs enables testing of the new master user password management feature.

---

34-34: LGTM! Improved string formatting using fmt.Sprintf.

Using fmt.Sprintf for string formatting is cleaner and more readable than string concatenation.

---

62-63: LGTM! Variable naming consistency improvement.

Changing from camelCase securityGroupId to PascalCase securityGroupID follows Go naming conventions where acronyms should be capitalized.

---

79-79: LGTM! Consistent variable naming with previous changes.

The variable name change maintains consistency with the earlier securityGroupID naming improvements.

---

82-83: LGTM! Variable naming consistency for DNS and ID acronyms.

Changing from camelCase delegatedDnsZoneId to PascalCase delegatedDNSZoneID follows Go naming conventions for acronyms.

---

103-104: LGTM! Consistent type improvements using any.

The type changes maintain consistency with the earlier improvements, using any instead of interface{} for better readability.

[mergify]

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

[RoseSecurity]

This improvement is stalled because the upstream module has an invalid count bug in the password logic when an SSM parameter is passed into the module

[RoseSecurity]

/terratest

[RoseSecurity]

@goruha This should be good to go now

[oycyc]

LGTM!

[github-actions]

These changes were released in v1.537.0.