Skip to content

Conversation

@llllllllll
Copy link
Contributor

addresses #94

Interestingly, this worked on PyPy without my change but it produced a very large serialized form.

@codecov-io
Copy link

codecov-io commented May 31, 2017

Codecov Report

Merging #95 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   79.88%   80.03%   +0.15%     
==========================================
  Files           2        2              
  Lines         522      526       +4     
  Branches      109      109              
==========================================
+ Hits          417      421       +4     
  Misses         75       75              
  Partials       30       30
Impacted Files Coverage Δ
cloudpickle/cloudpickle.py 79.92% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91eae7b...45793c2. Read the comment docs.

@pitrou
Copy link
Member

pitrou commented May 31, 2017

Oops, I pushed another PR in #96.

@rgbkrk
Copy link
Member

rgbkrk commented May 31, 2017

Since this one is passing and first currently, I lean towards merging this one. Y'all got this though.

@pitrou
Copy link
Member

pitrou commented May 31, 2017

PR #96 has more thorough tests, though. I'll fix the failing test on 2.6.

@llllllllll
Copy link
Contributor Author

Closing in favor of #96

@llllllllll llllllllll closed this May 31, 2017
@llllllllll llllllllll deleted the logger branch May 31, 2017 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants