Skip to content

Conversation

@pierreglaser
Copy link
Member

@pierreglaser pierreglaser commented Feb 10, 2020

Based on the (lack of) feedback from #338.

@pierreglaser
Copy link
Member Author

@llllllllll OK to drop Python 2?

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait for others to voice their opinion.

@ogrisel ogrisel added the ci downstream Signal the CI to run the test suite of all registered cloudpickle downstream projects. label Feb 10, 2020
@ogrisel
Copy link
Contributor

ogrisel commented Feb 10, 2020

All downstream tests still pass.

@ogrisel
Copy link
Contributor

ogrisel commented Feb 14, 2020

Ok no news in 4 days, let's merge this ;)

@ogrisel ogrisel merged commit 65b2408 into cloudpipe:master Feb 14, 2020
sthagen added a commit to sthagen/cloudpipe-cloudpickle that referenced this pull request Feb 14, 2020
Drop Python 2 support in cloudpickle (cloudpipe#342)
bavardage added a commit to bavardage/cloudpickle-feedstock that referenced this pull request Apr 28, 2020
cloudpickle dropped support for python 2.x as of cloudpipe/cloudpickle#342 (i.e. cloudpickle 1.4.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci downstream Signal the CI to run the test suite of all registered cloudpickle downstream projects.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants