Skip to content

Fix for CloudPickle Dropping Type Hints #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogrisel merged 5 commits into from
Jun 4, 2019
Merged

Fix for CloudPickle Dropping Type Hints #276

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c3f214
- Fix so older versions of typing are acknowledged other than python 3.7
achapkowski May 29, 2019
d92ce8a
- updated the test doc as requested.
achapkowski May 29, 2019
7969ddb
fixed test comment.
achapkowski May 29, 2019
9b14a66
- Added to CHANGES.md
achapkowski May 29, 2019
ad1809a
MAINT better phrasing
ogrisel Jun 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloudpickle/cloudpickle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ def save_function_tuple(self, func):
'name': func.__name__,
'doc': func.__doc__,
}
if hasattr(func, '__annotations__') and sys.version_info >= (3, 7):
if hasattr(func, '__annotations__') and sys.version_info >= (3, 4):
state['annotations'] = func.__annotations__
if hasattr(func, '__qualname__'):
state['qualname'] = func.__qualname__
Expand Down
4 changes: 2 additions & 2 deletions tests/cloudpickle_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1588,9 +1588,9 @@ def g():

self.assertEqual(f2.__doc__, f.__doc__)

@unittest.skipIf(sys.version_info < (3, 7),
@unittest.skipIf(sys.version_info < (3, 4),
"""This syntax won't work on py2 and pickling annotations
isn't supported for py36 and below.""")
isn't supported for py34 and below.""")
def test_wraps_preserves_function_annotations(self):
from functools import wraps

Expand Down