[BRANCH-0.4.x] BUG: Handle instancemethods of builtin types. #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a crash in Python 2 when serializing non-hashable instancemethods of built-in types.
Codecov Report
@@ Coverage Diff @@
## 0.4.x #154 +/- ##
==========================================
+ Coverage 83.61% 83.73% +0.12%
==========================================
Files 1 1
Lines 531 535 +4
Branches 97 97
==========================================
+ Hits 444 448 +4
Misses 63 63
Partials 24 24
Continue to review full report at Codecov.
|
Member
Author
|
This is the last one Spark dev found in apache/spark#20373. Now it's exactly matched with PySpark's. @rgbkrk, would you mind if I make/update a 0.4.3 section in both master and 0.4.x branches, and then ask to release 0.4.3? |
rgbkrk
approved these changes
Feb 6, 2018
Member
|
Yeah that makes sense to mention 0.4.x in the readme. What's your PyPI username for cutting the 0.4.3 release? |
Member
Author
|
Mine is hyukjinkwon. Let me update the README too shortly. |
Member
|
You're on cloudpickle on PyPI. Thanks much @HyukjinKwon! |
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Mar 8, 2018
## What changes were proposed in this pull request? The version of cloudpickle in PySpark was close to version 0.4.0 with some additional backported fixes and some minor additions for Spark related things. This update removes Spark related changes and matches cloudpickle [v0.4.3](https://github.com/cloudpipe/cloudpickle/releases/tag/v0.4.3): Changes by updating to 0.4.3 include: * Fix pickling of named tuples cloudpipe/cloudpickle#113 * Built in type constructors for PyPy compatibility [here](cloudpipe/cloudpickle@d84980c) * Fix memoryview support cloudpipe/cloudpickle#122 * Improved compatibility with other cloudpickle versions cloudpipe/cloudpickle#128 * Several cleanups cloudpipe/cloudpickle#121 and [here](cloudpipe/cloudpickle@c91aaf1) * [MRG] Regression on pickling classes from the __main__ module cloudpipe/cloudpickle#149 * BUG: Handle instance methods of builtin types cloudpipe/cloudpickle#154 * Fix <span>#</span>129 : do not silence RuntimeError in dump() cloudpipe/cloudpickle#153 ## How was this patch tested? Existing pyspark.tests using python 2.7.14, 3.5.2, 3.6.3 Author: Bryan Cutler <[email protected]> Closes apache#20373 from BryanCutler/pyspark-update-cloudpickle-42-SPARK-23159.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #145 to branch-0.4.x and fixes #144.