Preserve func.__qualname__ when defined #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
pitrou
reviewed
Nov 8, 2017
cloudpickle/cloudpickle.py
Outdated
| func = args[0] | ||
| keys = ['globals', 'defaults', 'dict', 'closure_values'] | ||
| state = dict(zip(keys, args[1:])) | ||
| state['module'] = None |
Member
There was a problem hiding this comment.
Is it ok to set __module__ to None? Or is it preferrable to skip it entirely?
Contributor
Author
There was a problem hiding this comment.
Good catch. I meant to change that.
Member
|
Kudos for doing this :-) |
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
==========================================
- Coverage 84.09% 78.34% -5.76%
==========================================
Files 2 2
Lines 522 531 +9
Branches 91 96 +5
==========================================
- Hits 439 416 -23
- Misses 62 84 +22
- Partials 21 31 +10
Continue to review full report at Codecov.
|
rgbkrk
approved these changes
Nov 8, 2017
Contributor
Author
|
@rgbkrk thanks for the merge. Do you want to release 0.4.2 too? Or shall I do it? |
Member
|
I’d love if you can make the release. |
Contributor
Author
|
0.4.2 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup for #128 to address @pitrou's comment: #128 (comment).
This is backward compatible with 0.4.0 and 0.4.1 and should make it easier to be forward compatible with future versions shall we need to pass additional function metadata.