Skip to content

Dynamic modules don't necessarily have a __package__ attribute #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgbkrk merged 2 commits into from
Aug 15, 2017
Merged

Dynamic modules don't necessarily have a __package__ attribute #116

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
279e456
Dynamic modules don't necessarily have a __package__ attribute
mariusvniekerk Aug 14, 2017
d1b1cf1
Added simple test case for the issue
mariusvniekerk Aug 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloudpickle/cloudpickle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ def _save_subimports(self, code, top_level_dependencies):
"""
# check if any known dependency is an imported package
for x in top_level_dependencies:
if isinstance(x, types.ModuleType) and x.__package__:
if isinstance(x, types.ModuleType) and hasattr(x, '__package__') and x.__package__:
Copy link
Member

@HyukjinKwon HyukjinKwon Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mariusvniekerk, I just happened to see this PR and I am interested in this change. Would it make sense to add a simple test here if it is not too difficult?

Copy link
Contributor Author

@mariusvniekerk mariusvniekerk Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

# check if the package has any currently loaded sub-imports
prefix = x.__name__ + '.'
for name, module in sys.modules.items():
Expand Down