Skip to content

Conversation

@maxrjones
Copy link
Collaborator

@maxrjones maxrjones commented Jun 9, 2025

closes #155

@netlify
Copy link

netlify bot commented Jun 9, 2025

Deploy Preview for harmonious-cajeta-5542ab ready!

Name Link
🔨 Latest commit 37901a6
🔍 Latest deploy log https://app.netlify.com/projects/harmonious-cajeta-5542ab/deploys/6847656c22c254000892a527
😎 Deploy Preview https://deploy-preview-166--harmonious-cajeta-5542ab.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cloudnativegeo cloudnativegeo deleted a comment from github-actions bot Jun 9, 2025
@maxrjones maxrjones changed the title WIP: Publish previews using netlify Publish previews using netlify Jun 9, 2025
@maxrjones maxrjones marked this pull request as ready for review June 9, 2025 22:42
@wildintellect
Copy link
Contributor

Are we deploying the whole site with Netlify, or just the previews? Just trying to figure out where the badge ought to go. The repo Readme seems a better place for now.

Also why is the ci.yml jobs empty?

@maxrjones
Copy link
Collaborator Author

maxrjones commented Jun 9, 2025

Are we deploying the whole site with Netlify, or just the previews? Just trying to figure out where the badge ought to go. The repo Readme seems a better place for now.

Just the previews. I put it in the current location in order to meet Netlify's requirements for their open source program:
Must feature a link to our service on your main page, or all internal pages

Also why is the ci.yml jobs empty?

It's not empty, it still contains the tests job:
image

Copy link
Collaborator

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@wildintellect wildintellect merged commit 640bf2e into staging Jun 10, 2025
1 check passed
@wildintellect wildintellect deleted the netlify branch June 10, 2025 17:41
wildintellect pushed a commit that referenced this pull request Jun 10, 2025
* Publish previews using netlify

* Remove GH preview workflow

* Remove staging explanation from contrib guide

* Remove pr-target-test job

* Add build with Netlify badge for open source program
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy Previews using Netlify

4 participants