-
Notifications
You must be signed in to change notification settings - Fork 31
Update Zarr content in slides and tweak formatting #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Update environment.yml * notebook run with bumped versions * remove colab fluff * revert immaterial changes * run on s3-style url * recalc multiples * typo
|
|
The slides are not rendering properly in the preview. I will look into whether this is an issue with the content or the preview action. |
Since the slides are also rendering incorrectly in https://guide.cloudnativegeo.org/pr-preview/pr-161/overview.html, this is an issue with the preview action rather than the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great diagram as-is so please ignore this if you don't agree as it may just be a matter of preference but I feel like most of these types of input output diagrams have inputs->outputs going from left to right.
abarciauskas-bgse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @maxrjones most of my comments are just minor wording adjustments. Thank you!
Co-authored-by: Aimee Barciauskas <[email protected]>
|
@abarciauskas-bgse if this looks good to you, can you formally mark it approved? We can handle the merging but would be nice to have the reviewer actually check it off first. |
❌ Deploy Preview for harmonious-cajeta-5542ab failed.
|
|
There are some outstanding questions but I don't mind approving as-is. |
Co-authored-by: Aimee Barciauskas <[email protected]>
Co-authored-by: Aimee Barciauskas <[email protected]>
sorry about this, I just addressed the remaining questions except the one that required Kyle's input. |
Co-authored-by: Julia Signell <[email protected]>
Co-authored-by: Kyle Barron <[email protected]>
This PR applies the recommendation in #17 to add data cubes to the overview of structures, applies some minor formatting tweaks (e.g., change append to footer so that image content isn't cut off, move notes on source so that there in no blank slide at the beginning), and updates the Zarr sections for newer developments.