Return connection when Connected #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [X] Read the [Contributing document](../blob/-/.github/CONTRIBUTING.md). Summary --------------- Context: Context: grpc/grpc-go#7029 Wait for status changed and return when connection is connected. Since DialContext has been removed, it's a bit unclear what needed to happen for connection to be ready for use. This code will bring back partial implementation of DialContext so that connection is ready. Backward Compatibility --------------- Breaking Change? **No**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context: Context: grpc/grpc-go#7029
Wait for status changed and return when connection is connected. Since
DialContext has been removed, it's a bit unclear what needed to happen
for connection to be ready for use. This code will bring back
partial implementation of DialContext so that connection is ready.
Backward Compatibility
Breaking Change? No