[Issue/Question] .cfignore does not respect folders

[jd-carroll]

Using the latest from mean.js, I installed the latest cli tools and I get the following:

$ cf push
Using manifest file c:\dev\artecha\inventory-management-meanjs\manifest.yml

Updating app mean in org inventory-management / space development as jdsalingerjr@gmail.com...
OK

Creating route mean-unsaccharine-arboriculture.cfapps.io...
OK

Binding mean-unsaccharine-arboriculture.cfapps.io to mean...
OK

Uploading mean...
FAILED
Error uploading application.
GetFileAttributesEx c:\dev\artecha\inventory-management-meanjs\node_modules\bower\node_modules\updat
e-notifier\node_modules\latest-version\node_modules\package-json\node_modules\got\node_modules\duple
xify\node_modules\end-of-stream\node_modules\once\node_modules\wrappy\package.json: The system canno
t find the path specified.

The node_modules is very clearly listed as an entry in the .cfignore file as node_modules/.

Is this a bug or am I missing something?

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/102327200.

[simonleung8]

The node_modules/will not be uploaded, however, CLI walks through all directories in order to determine what files need to be uploaded. Are you running into this issue under Windows? IIRC, Windows has a limit on how long a dir name can be.

[KrekkieD]

I explicitly set node_modules to be ignored in .cfignore and still it iterates through this dir. This is a really annoying thing on windows which indeed occurs once paths become too long, which depends on the modules you have installed.

I need to remove the folder in order to be able to push, and I need my entire team to know and understand this trick. Furthermore, if I had a local npm module linked, this could mean that I accidentally remove the linked module source as well (as deleting the folder carelessly will follow symlinks..), so this really is a pain.

I think it should give the .cfignore paths more respect before attempting iterating over something that serves no purpose.

[jd-carroll]

@simonleung8 That's completely ridiculous... Why would it care what's in an ignored directory? Can you please point me to where this code is and I will submit a PR to fix this issue.

[petereberlein]

I ran into the same problem that the CLI cannot deal with long paths on Windows, however, in my use case the folder structure is intended, ie. there is no .cfignore in it because I need all the files in this way.

It is certainly a good idea to not traverse folders with a .cfignore in it and that solves the issue for the original reporter, but I'd appreciate it very much, if the actual problem (the use of ancient Windows APIs that cannot deal with long paths) was fixed as well.

[cjmoran]

Same issue here; node_modules/ is listed in my .cfignore file but my app fails to push unless I move that folder elsewhere, due to cf looking through the deeply-nested directory tree. This wasn't happening with an older version of CF CLI (just upgraded today).

Uploading [app name]
FAILED
Error uploading application.
GetFileAttributesEx C:\Users\[redacted]\Documents\[redacted]\node_modules\webpack\node_modules\watchpack\node_modules\chokidar\node_modules\anymatch\node_modules\micromatch\node_modules\braces\node_modules\expand-range\node_modules\fill-range\node_modules\is-number\README.md: The system cannot find the path specified.

edit: Uninstalled CF CLI v6.12.4, downgraded to v6.12.0 and the problem disappeared. (Didn't test 6.12.1 - 6.12.3).

[dkoper]

Thanks for the additional details. I have prioritized the story in our backlog.

Same issue on Win7 for cf-cli-installer_6.13.0_winx64. The downgrade to v6.12.0 didn't work for me.
(checked both versions 32 an 64 Bit)

cf --version
cf version 6.12.0-8c65bbd-2015-06-29T17:18:54+00:00
cf --version
cf version 6.12.0-8c65bbd-2015-06-30T00:16:56+00:00

[maral]

What about this bug, are you guys dealing with this? Pretty annoying...

[krishicks]

We're looking at this issue now.

[krishicks]

Hi,

The latest edge release has a potential fix for this issue. I say potential because the story hasn't yet passed acceptance, but the binary is available at https://github.com/cloudfoundry/cli#downloads.

Please give it a try if you're experiencing this problem and let me know if it works.

[cjmoran]

The version you linked fixed it for me, thanks!

edit: spoke too soon... fixed it for the first project I tried, but another project is still having the issue, oddly enough. Both of these projects had the issue even on v6.12.0, and now only one does. Their .cfignores are completely identical.

Uploading [app name]
FAILED
Error uploading application.
GetFileAttributesEx C:\Users\[redacted]\Documents\[redacted]\cloudapp-ops\node_modules\babel-preset-es2015\node_modules\babel-plugin-transform-es2015-arrow-functions\node_modules\babel-runtime\node_modules\core-js\library\modules\es6.object.get-own-property-descriptor.js: The system cannot find the path specified.

npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "deploy"
npm ERR! node v4.1.0
npm ERR! npm  v2.14.3
npm ERR! code ELIFECYCLE
npm ERR! cloudapp-ops-view-server@0.0.1 deploy: `cf push`
npm ERR! Exit status 1

If it helps:

$ cf --version
C:\Program Files (x86)\CloudFoundry\cf.exe version 6.14.0+2654a47-2015-11-18

.cfignore:

*.iml
.idea/

logs/
*.log
npm-debug.log*
node_modules/

*.pid
*.seed

config.js