Skip to content

Use context from Golang stdlib #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aramprice merged 2 commits into from
Nov 14, 2025
Merged

Use context from Golang stdlib #125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dd2566
Use `context` from Golang stdlib
aramprice Nov 14, 2025
91e4750
Context in stdlib recommends type'd keys
aramprice Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/bosh-dns/dns/server/handlers/cache_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
package handlers

import (
"context"

"code.cloudfoundry.org/clock"
boshlog "github.com/cloudfoundry/bosh-utils/logger"
"github.com/coredns/coredns/plugin/cache"
"github.com/miekg/dns"
"golang.org/x/net/context"

"bosh-dns/dns/server/handlers/internal"
"bosh-dns/dns/server/records/dnsresolver"
Expand All @@ -24,6 +25,12 @@ type requestContext struct {
fromCache bool
}

type ctxKey int

const (
indicatorKey ctxKey = iota
)

func NewCachingDNSHandler(next dns.Handler, truncater dnsresolver.ResponseTruncater, clock clock.Clock, logger boshlog.Logger) CachingDNSHandler {
ca := cache.New()
ca.Next = corednsHandlerWrapper{Next: next}
Expand Down Expand Up @@ -54,7 +61,7 @@ func (c CachingDNSHandler) ServeDNS(w dns.ResponseWriter, r *dns.Msg) {
indicator := &requestContext{
fromCache: true,
}
requestContext := context.WithValue(context.Background(), "indicator", indicator)
requestContext := context.WithValue(context.Background(), indicatorKey, indicator)

before := c.clock.Now()
_, err := c.ca.ServeDNS(requestContext, truncatingWriter, r)
Expand All @@ -73,7 +80,7 @@ type corednsHandlerWrapper struct {
}

func (w corednsHandlerWrapper) ServeDNS(ctx context.Context, writer dns.ResponseWriter, m *dns.Msg) (int, error) {
requestContext := ctx.Value("indicator").(*requestContext)
requestContext := ctx.Value(indicatorKey).(*requestContext)
requestContext.fromCache = false

w.Next.ServeDNS(writer, m)
Expand Down
Loading