Fix unit test failures on dependency bump#110
Merged
Conversation
The latest version of coredns deep copies the response object before mutating it, which results in some slight discrepancies between our mock object and the value stored in the cache. In the past, the actual mock object would get mutated, so it would pass Equals testing in the units. That no longer happens, so we need to update the mock object to match the values we expect to actually get cached. This fix should address the ci failure [here](https://ci-demo.bosh-ecosystem.cf-app.com/teams/main/pipelines/bosh-dns-release/jobs/bump-deps/builds/290)
aramprice
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version of coredns deep copies the response object before mutating it, which results in some slight discrepancies between our mock object and the value stored in the cache. In the past, the actual mock object would get mutated, so it would pass Equals testing in the units. That no longer happens, so we need to update the mock object to match the values we expect to actually get cached.
This fix should address the ci failure
here