Skip to content

Add the nodejs_als flag for the svelte template#9940

Merged
petebacondarwin merged 1 commit intocloudflare:mainfrom
stof:patch-1
Aug 11, 2025
Merged

Add the nodejs_als flag for the svelte template#9940
petebacondarwin merged 1 commit intocloudflare:mainfrom
stof:patch-1

Conversation

@stof
Copy link
Contributor

@stof stof commented Jul 11, 2025

Recent sveltekit versions rely on node:async_hooks to access AsyncLocalStorage

See sveltejs/kit#13668 for the report.


  • Tests
    • Tests included
    • Tests not necessary because: it only changes a template for create-cloudflare, which is not something covered by tests.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this is improving the existing template for svelte to work out of the box
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a wrangler change. It changes create-cloudflare

@stof stof requested a review from a team July 11, 2025 21:39
@stof stof requested a review from a team as a code owner July 11, 2025 21:39
@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2025

🦋 Changeset detected

Latest commit: 9e07693

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 14, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9940

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9940

miniflare

npm i https://pkg.pr.new/miniflare@9940

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9940

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9940

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9940

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9940

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9940

wrangler

npm i https://pkg.pr.new/wrangler@9940

commit: 9e07693

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but could you fill out the rest of the PR template?

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 14, 2025
@stof
Copy link
Contributor Author

stof commented Jul 15, 2025

@penalosa does this need a wrangler v3 backport ?

@penalosa
Copy link
Contributor

@stof No, since it's a create-cloudflare change

Recent sveltekit versions rely on `node:async_hooks` to access `AsyncLocalStorage`
@stof
Copy link
Contributor Author

stof commented Jul 15, 2025

@penalosa I filled the PR template, and I also applied the same fix for the sibling template targeting Cloudflare Pages instead of Cloudflare Workers.

@penalosa
Copy link
Contributor

@stof great, thank you! I'll get this merged tomorrow for release later this week

@petebacondarwin petebacondarwin merged commit 46df88c into cloudflare:main Aug 11, 2025
32 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Aug 11, 2025
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Aug 11, 2025
@holopin-bot
Copy link

holopin-bot bot commented Aug 11, 2025

Congratulations @stof, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cme6syb84020608l5nh6b4izr

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes an open-source contribution, big or small

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants