Skip to content

Conversation

@GregBrimble
Copy link
Contributor

@GregBrimble GregBrimble commented Feb 12, 2025

WC-3184.

There's a case that when comparing extreme manifests, (very high highs and very low lows), we'd encounter a divide by zero error. This fixes that issue by adding early checks before the calculation against what would otherwise be out-of-bounds search operations.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

@GregBrimble GregBrimble requested review from a team as code owners February 12, 2025 02:52
@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: 0f8de02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workers-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13277022220/npm-package-wrangler-8105

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8105/npm-package-wrangler-8105

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13277022220/npm-package-wrangler-8105 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13277022220/npm-package-cloudflare-workers-bindings-extension-8105 -O ./cloudflare-workers-bindings-extension.0.0.0-vf429cba97.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vf429cba97.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13277022220/npm-package-create-cloudflare-8105 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13277022220/npm-package-cloudflare-kv-asset-handler-8105

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13277022220/npm-package-miniflare-8105

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13277022220/npm-package-cloudflare-pages-shared-8105

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13277022220/npm-package-cloudflare-unenv-preset-8105

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13277022220/npm-package-cloudflare-vite-plugin-8105

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13277022220/npm-package-cloudflare-vitest-pool-workers-8105

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13277022220/npm-package-cloudflare-workers-editor-shared-8105

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13277022220/npm-package-cloudflare-workers-shared-8105

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13277022220/npm-package-cloudflare-workflows-shared-8105

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250204.0
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@GregBrimble GregBrimble merged commit f2e6e74 into main Feb 12, 2025
27 of 28 checks passed
@GregBrimble GregBrimble deleted the fix-interpolation-search-for-extreme-manifests branch February 12, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants